Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporarily use windows-2019 #719

Merged
merged 2 commits into from
Feb 17, 2022
Merged

Temporarily use windows-2019 #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8ca01d
Temporarily use windows-2019
christophebedard Feb 4, 2022
aca7518
Add note about needing windows-2019 to README
christophebedard Feb 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,11 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macOS-latest, windows-latest]
os: [macOS-latest, windows-2019]
ros_distribution: [foxy, galactic]
env:
INSTALL_TYPE: ${{ matrix.os == 'windows-latest' && 'merged' || 'default' }}
INSTALL_PATH: ${{ matrix.os == 'windows-latest' && 'install/share' || 'install' }}
INSTALL_TYPE: ${{ matrix.os == 'windows-2019' && 'merged' || 'default' }}
INSTALL_PATH: ${{ matrix.os == 'windows-2019' && 'install/share' || 'install' }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
Expand Down Expand Up @@ -202,12 +202,12 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macOS-latest, windows-latest, ubuntu-20.04]
os: [macOS-latest, windows-2019, ubuntu-20.04]
ros_distribution: [foxy, galactic, rolling]
env:
DISTRO_REPOS_URL: "https://raw.githubusercontent.com/ros2/ros2/${{ matrix.ros_distribution == 'rolling' && 'master' || matrix.ros_distribution }}/ros2.repos"
INSTALL_TYPE: ${{ matrix.os == 'windows-latest' && 'merged' || 'default' }}
INSTALL_PATH: ${{ matrix.os == 'windows-latest' && 'install/share' || 'install' }}
INSTALL_TYPE: ${{ matrix.os == 'windows-2019' && 'merged' || 'default' }}
INSTALL_PATH: ${{ matrix.os == 'windows-2019' && 'install/share' || 'install' }}
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2.4.0
Expand Down
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ vcstool

On Linux, the setup can be done through [`ros-tooling/setup-ros`](https://github.com/ros-tooling/setup-ros), or by running the action in a Docker image containing the appropriate binaries.

**Note**: for Windows, `action-ros-ci` currently needs to be run on `windows-2019` or needs another action to install Visual Studio 2019.

## Overview

The action first assembles a workspace, then runs `colcon build`, and `colcon test` in it.
Expand Down