-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup containers #124
Cleanup containers #124
Conversation
@dirk-thomas @tfoote How can I test this? Thanks. |
As long as @tfoote Can comment on how you can test this (with the current build farm). Regarding the |
We can go into a specific job config and edit the branch of ros_buildfarm that it checks out and then manually trigger it. |
@dirk-thomas I agree, but since docker does not provide a @tfoote I've triggered this: |
Yes please, I would say it's much cleaner and similar to common command line arguments. The single run won't tell us much. I think we only see the effect if we start from a "clean" slave and all jobs running on that slave use this change for a while. Then we can look at the list after e.g. a day or so. |
…egardless of the exit status
4c04d0a
to
01e8155
Compare
@dirk-thomas Done 01e8155 |
Yeah, it's an aggregate state thing and it will only show as effective if we deploy it for an active build cycle. If we validate it on a few jobs as not breaking then we can go ahead and deploy it and make sure to come back and check that there is not significant accumulation after the time of deployment. |
I triggered this job to check that the latest changes are fine: |
The build passed. Though I'm not sure if it took. the only place I see --force-rm is in the checkout log at the top There are two instances of docker build where I do not see --force-rm http://54.183.26.131:8080/view/Jbin_uT64/job/Jbin_uT64__ackermann_msgs__ubuntu_trusty_amd64__binary/21/console |
@tfoote there's a couple of |
Yeah, you're right they're baked in. The good news is we have a test farm now. If you tweak this reconfigure job http://54.183.26.131:8080/view/Manage/job/Jrel_reconfigure-jobs/configure jade on the test farm will have your changes after it reconfigures. |
Triggered this job: http://54.183.26.131:8080/view/Manage/job/Jrel_reconfigure-jobs/330/ |
The generated job now has And triggered a new one: |
I believe this is ready for merging, though we will see the effects of this after a few more runs. |
looks good. lets land it and we can leave the ticket open to check on the slaves in a few days. |
@tfoote I've updated the reconfigure job to point to master, instead of to this branch. |
This forces cleanup of intermediate containers. I also added
=true
to--rm
to make the command line a bit more expressive.Connects to #120