Upgrade puma gem to 5.2.1 #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The existent puma gem version (4.3.5) raises an error when trying to install on Mac.
The error has been reported here and it's tied specifically to the 4.3.5 version of the gem and MacOS 15.5.5/MacOS Big Sur.
It's solved by adding a flag to the installation of the gem, like this:
gem install puma:4.3.5 -- --with-cflags="-Wno-error=implicit-function-declaration"Nevertheless, we considered useful to upgrade the gem to the latest version where the problem is solved.
Note: #aa2ba51 Fixes flaky test caused by a misshaped name on Faker::App.name. You can check the failed build here.