fix empty file decode issue #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Baaboud thanks for the PR. Can you add a test so we prevent regressions? |
amaury901130
approved these changes
Jan 9, 2024
Baaboud
force-pushed
the
issue_decode_empty_file
branch
from
1fac35d
to
8c4e20d
Compare
santib
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
issue
we get error when there is an empty file is uploaded
the issue happens in the decode process for data part because it is empty
lib/active_storage_support/base64_attach.rb:22 decoded_data = Base64.decode64(data)here the data is
niland will get an errorOther Information
I think we should consider allowing empty data part to be blank like I did in my PR here or adding validation to allow or prevent empty files