Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fix(patch): do not emit empty js assets #1417

Merged
merged 4 commits into from May 19, 2022
Merged

馃悰 fix(patch): do not emit empty js assets #1417

merged 4 commits into from May 19, 2022

Conversation

kellymears
Copy link
Member

@kellymears kellymears commented May 19, 2022

Overview

Adds webpack-remove-empty-scripts plugin extension to prevent empty assets from being emitted.

See this webpack issue: webpack/webpack#7300. The suggested course of resolution doesn't seem to work. But the plugin works well.

  • 馃悰 fix(patch): add webpack-remove-empty-scripts
  • 馃浖 improve(none): use @production decorator
  • 馃И test(none): update tests
  • 馃摝 deps(patch): lockfile

closes: #1416

Type of change

  • PATCH: Backwards compatible bug fix

This PR includes breaking changes to the following core packages:

  • none

This PR includes breaking changes to the follow extensions:

  • none

Dependencies

Adds

Removes

  • none

@github-actions github-actions bot added @roots/bud dependencies Pull requests that update a dependency file test labels May 19, 2022
@kellymears kellymears merged commit b3771a8 into main May 19, 2022
@kellymears kellymears deleted the fix-1416 branch May 19, 2022 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file @roots/bud test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JS file always generated even when no entry defined
1 participant