Update go.mod to have go1.17 as the minmium version #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
manugupt1
commented
Feb 27, 2022
manugupt1
commented
- The Dockerfile already builds for go1.17. Therefore updating the go.mod to go1.17.
- Update README instructions to use go install instead of go get as go get won't add executable binaries in the future.
manugupt1
force-pushed
the
go-1.17
branch
5 times, most recently
from
73146c4
to
524fce6
Compare
AkihiroSuda
reviewed
Mar 2, 2022
.github/workflows/main.yaml
Outdated
| @@ -93,8 +93,7 @@ jobs: | |||
| - name: "Check out" | |||
| uses: actions/checkout@v2 | |||
| - name: "Build integration test image" | |||
| # Docker 20.10.x builds RootlessKit with Go 1.16 (as of Docker 20.10.11), so we use Go 1.16 as well here. | |||
There was a problem hiding this comment.
This is still true
https://github.com/moby/moby/blob/v20.10.12/Dockerfile#L6
There was a problem hiding this comment.
Oh thanks! I can close this PR or are there bits that seem okay to you and I should keep
There was a problem hiding this comment.
Docker 20.10.15 will use Go 1.17, so we can drop 1.16 (and add 1.17 instead)
|
LGTM now, but could you rebase? |
Update go.mod to specify go1.17 as the minimum go version. Also run go mod tidy on it. Signed-off-by: Manu Gupta <manugupt1@gmail.com>
Signed-off-by: Manu Gupta <manugupt1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.