Automate client tests with karma #126

Autre31415 · 2017-04-18T00:17:58Z

karma is a nifty module which allows us to run client side tests in the console. All of its functionality is split into separate modules so the way it behaves is very configurable.

This particular setup will run our client-side tests in Chrome by inputting the command karma start. (Chrome needs to be installed, which shouldn't be a problem for most of the planet ;) )

This functionality has also been brought over to travis and all code coverage is captured.

Note: Currently the minification test is failing on the client due to some quirkyness of the compile step. For the moment I'm setting teddy.minify(true) on the client side to make it pass, but I plan to investigate the quirkiness further.

coveralls · 2017-04-18T00:21:00Z

Coverage increased (+2.6%) to 89.979% when pulling 51167ad on Autre31415:karmaTesting into e64d8af on kethinov:master.

kethinov · 2017-04-18T04:55:29Z

package.json

@@ -56,7 +63,8 @@
  "scripts": {
    "test": "cross-env NODE_ENV=test mocha --recursive test",
    "eslint": "eslint .",
-    "cover": "cross-env NODE_ENV=cover istanbul cover _mocha --recursive test"
+    "cover": "cross-env NODE_ENV=cover istanbul cover _mocha --recursive test",
+    "karma": "karma start"


change this to test-client

add another for test-server

make npm test run both the server and client tests

kethinov · 2017-04-18T04:55:50Z

package.json

@@ -56,7 +63,8 @@
  "scripts": {
    "test": "cross-env NODE_ENV=test mocha --recursive test",
    "eslint": "eslint .",
-    "cover": "cross-env NODE_ENV=cover istanbul cover _mocha --recursive test"
+    "cover": "cross-env NODE_ENV=cover istanbul cover _mocha --recursive test",


change cover to coverage

actually no, alias coverage to cover, have both

kethinov · 2017-04-18T05:01:53Z

karma.conf.js

@@ -0,0 +1,50 @@
+// Karma configuration


any way to suppress this error?

kethinov · 2017-04-18T05:03:36Z

test/client.html

                teddy.templates[template] = teddy.compile(req.response || req.responseText);
-                counter++;
-                if (counter === templateLength) {
+                if (counter++ === templateLength - 1) {


clever but no

coveralls · 2017-04-20T16:58:56Z

Coverage increased (+2.6%) to 89.979% when pulling 5b0bb10 on Autre31415:karmaTesting into e64d8af on kethinov:master.

kethinov · 2017-04-22T01:27:36Z

Merge in the latest changes from 0.4.10.

…Testing

coveralls · 2017-04-22T08:05:12Z

Coverage increased (+2.6%) to 90.113% when pulling 4207254 on Autre31415:karmaTesting into 24066e2 on kethinov:master.

coveralls · 2017-04-22T08:09:43Z

Coverage increased (+2.6%) to 90.113% when pulling e54d865 on Autre31415:karmaTesting into 24066e2 on kethinov:master.

kethinov · 2017-04-22T21:06:30Z

We should suppress these in the karma logs:

WARN: '<include> element found with no src attribute. Ignoring element.'
WARN: '<include> element found which references a nonexistent template ("noExist.html"). Ignoring element.'
WARN: '<arg> element found with no attribute. Ignoring parent <include> element. (<include src="misc/variable.html">)'
ERROR: 'Render aborted due to max number of passes (100) exceeded; there is a possible infinite loop in your template logic.'
WARN: 'teddy.render attempted to render a template which doesn't exist: .html'
WARN: 'teddy.render attempted to render a template which doesn't exist: .html'
WARN: 'teddy.render attempted to render a template which doesn't exist: .html'
WARN: 'loop element found with no "val" attribute. Ignoring element.'
WARN: 'loop element found with no "through" attribute. Ignoring element.'
WARN: 'loop element found with no "val" attribute. Ignoring element.

kethinov · 2017-04-23T18:14:33Z

Will need to resolve the merge conflict and bring in 0.4.11.

…Testing

coveralls · 2017-04-27T19:53:19Z

Coverage increased (+5.2%) to 90.844% when pulling 0dd1447 on Autre31415:karmaTesting into fc78793 on kethinov:master.

…to clientRedesign

kethinov · 2017-05-03T04:52:32Z

Can we display the full test results on the karma side similar to how mocha does it so we have more context as to which test failed?
Make a link to Any way to suppress 'mocha div missing' error? karma-runner/karma-mocha#176 in the CSS comments which hide the error

coveralls · 2017-05-03T16:50:56Z

Coverage increased (+4.0%) to 89.548% when pulling 408c343 on Autre31415:karmaTesting into fc78793 on kethinov:master.

coveralls · 2017-05-03T17:39:20Z

Coverage increased (+4.6%) to 90.151% when pulling d6cc9a5 on Autre31415:karmaTesting into fc78793 on kethinov:master.

coveralls · 2017-05-03T17:49:23Z

Coverage increased (+5.6%) to 91.165% when pulling fe19d48 on Autre31415:karmaTesting into fc78793 on kethinov:master.

Autre31415 added 4 commits April 16, 2017 17:22

karma testing tweaks

22fe6e2

add karma integration to travis

13dce6e

remove console.log

7cf1801

dump the flushCache

51167ad

kethinov reviewed Apr 18, 2017

View reviewed changes

karma.conf.js

@@ -0,0 +1,50 @@

// Karma configuration

Copy link

Member

kethinov Apr 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any way to suppress this error?

kethinov reviewed Apr 18, 2017

View reviewed changes

Autre31415 added 2 commits April 20, 2017 12:50

create global hooks

d1f1e76

better test scripts

5b0bb10

Autre31415 added 2 commits April 22, 2017 03:54

Merge branch 'master' of https://github.com/kethinov/teddy into karma…

8095e42

…Testing

bring in missing client test

4207254

tweak client.html

e54d865

Autre31415 added 2 commits April 22, 2017 04:10

modify client

c703435

I guess 400 isn't always enough

710998c

set verbosity to 0 on client tests

925a898

Autre31415 added 2 commits April 23, 2017 14:33

Merge branch 'master' of https://github.com/kethinov/teddy into karma…

27ac134

…Testing

hide the mocha div error

0dd1447

Autre31415 added 2 commits May 1, 2017 02:12

Merge branch 'karmaTesting' of https://github.com/Autre31415/teddy in…

4f135ec

…to clientRedesign

new client test prototype

c12ff12

lots of cool stuff

408c343

more tweaks

d6cc9a5

use setDefaultParam function

fe19d48

kethinov merged commit 67fe52d into rooseveltframework:master May 3, 2017

Autre31415 deleted the karmaTesting branch May 3, 2017 22:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Automate client tests with karma #126

Automate client tests with karma #126

Autre31415 commented Apr 18, 2017

coveralls commented Apr 18, 2017

kethinov Apr 18, 2017

kethinov Apr 18, 2017

kethinov Apr 18, 2017

kethinov Apr 18, 2017

kethinov Apr 18, 2017

coveralls commented Apr 20, 2017

kethinov commented Apr 22, 2017

coveralls commented Apr 22, 2017

coveralls commented Apr 22, 2017

kethinov commented Apr 22, 2017 •

edited

kethinov commented Apr 23, 2017

coveralls commented Apr 27, 2017

kethinov commented May 3, 2017

coveralls commented May 3, 2017

coveralls commented May 3, 2017

coveralls commented May 3, 2017

Automate client tests with karma #126

Automate client tests with karma #126

Conversation

Autre31415 commented Apr 18, 2017

coveralls commented Apr 18, 2017

kethinov Apr 18, 2017

Choose a reason for hiding this comment

kethinov Apr 18, 2017

Choose a reason for hiding this comment

kethinov Apr 18, 2017

Choose a reason for hiding this comment

kethinov Apr 18, 2017

Choose a reason for hiding this comment

kethinov Apr 18, 2017

Choose a reason for hiding this comment

coveralls commented Apr 20, 2017

kethinov commented Apr 22, 2017

coveralls commented Apr 22, 2017

coveralls commented Apr 22, 2017

kethinov commented Apr 22, 2017 • edited

kethinov commented Apr 23, 2017

coveralls commented Apr 27, 2017

kethinov commented May 3, 2017

coveralls commented May 3, 2017

coveralls commented May 3, 2017

coveralls commented May 3, 2017

kethinov commented Apr 22, 2017 •

edited