remove txid table if txindex is enabled #871
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonilol
force-pushed
the
optional-txid
branch
4 times, most recently
from
89750f2
to
b1efcff
Compare
|
i let this rot for too long, will look into it again after #1043 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #798
depends on #773 for clippy in the ci to succeed (there is a clippy bug in this rust version)
With bitcoind's txindex the txid column family (i called this 'table' in the linked issue) is not necessary and takes up about a quarter of the DB on disk. On testnet my DB was 2.62 GB before this PR, and 1.91 after, on mainnet I expect it to free around 10 GB of the 40 GB currently used.
If txindex is turned on, the txid cf will be emptied and not indexed, if it is turned off, electrs will reindex this cf
todo: