https://github.com/w3c/FileAPI/issues/41

romainmenke · Jul 14, 2020 · 968a138 · 968a138
1 parent 10f4c17
commit 968a138
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/polyfills/File/polyfill.js b/polyfills/File/polyfill.js
@@ -50,8 +50,12 @@
 		// Not our concern here.
 
 		// 4.1.2 https://w3c.github.io/FileAPI/#file-constructor
-		// Let n be a new string of the same size as the fileName argument to the constructor. Copy every character from fileName to n, replacing any "/" character (U+002F SOLIDUS) with a ":" (U+003A COLON).
-		var n = fileName.toString().replace(/\//g, ':');
+		// Let n be a new string of the same size as the fileName argument to the constructor.
+		// 
+		// Copy every character from fileName to n, replacing any "/" character (U+002F SOLIDUS) with a ":" (U+003A COLON).
+		// WARNING : This part of the spec is still debated and UA's implement inconsistently. https://github.com/w3c/FileAPI/issues/41
+		// When spec settles maybe add : .replace(/\//g, ':')
+		var n = fileName.toString();
 
 		var options;
 		if (2 < arguments.length) {

diff --git a/polyfills/File/tests.js b/polyfills/File/tests.js
@@ -54,7 +54,8 @@ describe('File', function() {
 		proclaim.equal(e.name, 'stringer');
 	});
 
-	// https://bugs.chromium.org/p/chromium/issues/detail?id=1105171
+	// Chromium issue : https://bugs.chromium.org/p/chromium/issues/detail?id=1105171
+	// Spec debate : https://github.com/w3c/FileAPI/issues/41
 	// it("implements .name escaping", function () {
 	// 	// 4.1.2 https://w3c.github.io/FileAPI/#file-constructor
 	// 	// Let n be a new string of the same size as the fileName argument to the constructor.