Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline guide into rollup #172

Merged
merged 4 commits into from Dec 20, 2018
Merged

Inline guide into rollup #172

merged 4 commits into from Dec 20, 2018

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Dec 20, 2018

This will remove the English guide from the repo and add rollup as a submodule to take the guide from there. Please check out the updated README on how to update the guide. At the moment, this PR points to the branch in rollup containing the guide. Publishing should be as straightforward as before. Updating the guide now means updating the commit the submodule points to.

This also removes markdown linting as this is added to rollup itself now.

The corresponding Rollup PR is rollup/rollup#2602

…ollup

(needs to be changed to use the release branch at some point)
Add script to update the English guide from rollup
Copy link
Contributor

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.

* Add English docs to repo

* Update PR template to mention documentation requirement

* Add guide markdown linting
@lukastaegert lukastaegert merged commit ace232a into master Dec 20, 2018
@lukastaegert lukastaegert deleted the inline-en-docs-into-rollup branch December 20, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants