Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint to v9 #5467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 12, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint (source) ^8.57.0 -> ^9.2.0 age adoption passing confidence

Release Notes

eslint/eslint (eslint)

v9.2.0

Compare Source

v9.1.1

Compare Source

v9.1.0

Compare Source

v9.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - "before 4am on Friday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link
Contributor Author

renovate bot commented Apr 12, 2024

⚠ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: package-lock.json
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @typescript-eslint/eslint-plugin@7.8.0
npm error Found: eslint@9.2.0
npm error node_modules/eslint
npm error   dev eslint@"^9.2.0" from the root project
npm error   peer eslint@"^6.0.0 || ^7.0.0 || >=8.0.0" from @eslint-community/eslint-utils@4.4.0
npm error   node_modules/@eslint-community/eslint-utils
npm error     @eslint-community/eslint-utils@"^4.4.0" from @typescript-eslint/utils@7.8.0
npm error     node_modules/@typescript-eslint/utils
npm error       @typescript-eslint/utils@"7.8.0" from @typescript-eslint/eslint-plugin@7.8.0
npm error       node_modules/@typescript-eslint/eslint-plugin
npm error         dev @typescript-eslint/eslint-plugin@"^7.8.0" from the root project
npm error         1 more (@vue/eslint-config-typescript)
npm error       1 more (@typescript-eslint/type-utils)
npm error     @eslint-community/eslint-utils@"^4.4.0" from eslint-plugin-unicorn@52.0.0
npm error     node_modules/eslint-plugin-unicorn
npm error       dev eslint-plugin-unicorn@"^52.0.0" from the root project
npm error     2 more (eslint-plugin-vue, eslint)
npm error   6 more (@vue/eslint-config-prettier, eslint-config-prettier, ...)
npm error
npm error Could not resolve dependency:
npm error peer eslint@"^8.56.0" from @typescript-eslint/eslint-plugin@7.8.0
npm error node_modules/@typescript-eslint/eslint-plugin
npm error   dev @typescript-eslint/eslint-plugin@"^7.8.0" from the root project
npm error   @typescript-eslint/eslint-plugin@"^7.1.1" from @vue/eslint-config-typescript@13.0.0
npm error   node_modules/@vue/eslint-config-typescript
npm error     dev @vue/eslint-config-typescript@"^13.0.0" from the root project
npm error
npm error Conflicting peer dependency: eslint@8.57.0
npm error node_modules/eslint
npm error   peer eslint@"^8.56.0" from @typescript-eslint/eslint-plugin@7.8.0
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     dev @typescript-eslint/eslint-plugin@"^7.8.0" from the root project
npm error     @typescript-eslint/eslint-plugin@"^7.1.1" from @vue/eslint-config-typescript@13.0.0
npm error     node_modules/@vue/eslint-config-typescript
npm error       dev @vue/eslint-config-typescript@"^13.0.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
npm error
npm error For a full report see:
npm error /tmp/renovate/cache/others/npm/_logs/2024-05-06T21_21_35_967Z-eresolve-report.txt

npm error A complete log of this run can be found in: /tmp/renovate/cache/others/npm/_logs/2024-05-06T21_21_35_967Z-debug-0.log

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ❌ Failed (Inspect) May 6, 2024 9:22pm

Copy link

github-actions bot commented Apr 12, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#renovate/eslint-9.x

Notice: Ensure you have installed Rust nightly. If you haven't installed it yet, please first see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust, then see https://rust-lang.github.io/rustup/concepts/channels.html to learn how to install Rust nightly.

or load it into the REPL:
https://rollupjs.org/repl/?pr=5467

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.81%. Comparing base (00f0681) to head (222685c).

❗ Current head 222685c differs from pull request most recent head 581fa16. Consider uploading reports for the commit 581fa16 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5467      +/-   ##
==========================================
- Coverage   98.81%   98.81%   -0.01%     
==========================================
  Files         238      238              
  Lines        9540     9451      -89     
  Branches     2437     2408      -29     
==========================================
- Hits         9427     9339      -88     
+ Misses         48       47       -1     
  Partials       65       65              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert
Copy link
Member

Effectively, we are waiting for @typescript-eslint/eslint-plugin to support ESLint 9. Once this is the case, there is a long migration guide we need to look through.

https://eslint.org/docs/latest/use/migrate-to-9.0.0

For us, I expect it mostly means we need to migrate to the new flat config format, which has its own migration guide

https://eslint.org/docs/latest/use/configure/migration-guide

Copy link

github-actions bot commented May 6, 2024

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.013 ± 0.038 8.989 9.057 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.016 ± 0.032 8.986 9.050 1.00 ± 0.01

Internal benchmark

  • BUILD: 8064ms, 749 MB
    • initialize: 0ms, 26.1 MB
    • generate module graph: 3129ms, 574 MB
      • generate ast: 1513ms, 567 MB
    • sort and bind modules: 443ms, 619 MB
    • mark included statements: 4477ms, 749 MB
      • treeshaking pass 1: 1513ms, 715 MB
      • treeshaking pass 2: 728ms, 743 MB
      • treeshaking pass 3: 287ms, 744 MB
      • treeshaking pass 4: 267ms, 749 MB
      • treeshaking pass 5: 308ms, 746 MB
      • treeshaking pass 6: 255ms, 753 MB
      • treeshaking pass 7: 241ms, 754 MB
      • treeshaking pass 8: 233ms, 756 MB
      • treeshaking pass 9: 215ms, 753 MB
      • treeshaking pass 10: 214ms, 751 MB
      • treeshaking pass 11: 211ms, 749 MB
  • GENERATE: 876ms, 1.03 GB
    • initialize render: 0ms, 914 MB
    • generate chunks: 86ms, 927 MB
      • optimize chunks: 0ms, 917 MB
    • render chunks: 772ms, 999 MB
    • transform chunks: 16ms, 1.03 GB
    • generate bundle: 0ms, 1.03 GB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant