Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize resolveId source #5336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btea
Copy link
Contributor

@btea btea commented Jan 10, 2024

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

On the Windows platform, the path containing double backslashes may cause an error when reading the file.

Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 11:53am

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1837203) 98.81% compared to head (2003cc0) 98.81%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5336   +/-   ##
=======================================
  Coverage   98.81%   98.81%           
=======================================
  Files         232      232           
  Lines        8983     8983           
  Branches     2342     2342           
=======================================
  Hits         8877     8877           
  Misses         46       46           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukastaegert
Copy link
Member

Unfortunately, this looks to me like a breaking change. Could you please give a test case which problem you are trying to solve?

@btea
Copy link
Contributor Author

btea commented Jan 11, 2024

This is a issue submitted by someone in the vite repository. I tried to fix this problem on the vite side, and it just normalized the id received by the plugin transform hook. So I tried normalizing the ids on the rollup side.

Below are the relevant warehouse links and error screenshots, I hope they can be helpful.

https://github.com/movahhedi/vite-bug-inline-css

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants