ci: avoid unnecessary release builds

[cijiugechu]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

Description

Non-release environments will not trigger a release build and will use a dev build instead, reducing build time.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rollup	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 15, 2023 7:05am

[codecov]

Codecov Report

Merging #5191 (a804223) into master (f52a2eb) will not change coverage.
Report is 9 commits behind head on master.
The diff coverage is n/a.

❗ Current head a804223 differs from pull request most recent head f6bc9cd. Consider uploading reports for the commit f6bc9cd to get more accurate results

@@           Coverage Diff           @@
##           master    #5191   +/-   ##
=======================================
  Coverage   98.86%   98.86%           
=======================================
  Files         230      230           
  Lines        8805     8805           
  Branches     2314     2314           
=======================================
  Hits         8705     8705           
  Misses         39       39           
  Partials       61       61           

[lukastaegert]

Will this not just result in us publishing dev builds because the artifacts are not built during the publish job but during the build job where the ROLLUP_RELEASE variable is not set?

[cijiugechu]

Will this not just result in us publishing dev builds because the artifacts are not built during the publish job but during the build job where the ROLLUP_RELEASE variable is not set?

Is there a scenario where building and releasing occur outside the CI environment?

[lukastaegert]

Publishing will only happen on CI, but building does not happen during the publish phase and does not have the environment variable set. So you would need to set it conditionally.

[lukastaegert]

I think this looks really interesting. I still think, though, that this would publish dev builds because the env: ROLLUP_RELEASE: 'releasing' is only set during the publish job and not during the build job.
I would expect something like

env:
  BUILD_ARTEFACTS: "${{ startsWith(github.ref_name, 'v4') && 'build' || 'dev' }}"

added to the build job, which would use the same condition as the publish job.

Also, maybe BUILD_ARTEFACTS: "release" would be less confusing than "build" because we are building them in any case, but we either build the "release" or the "dev" version

[lukastaegert]

As test needs build, this should not be needed (but of course does not hurt, either)

[lukastaegert]

Instead of using exec, there is a nice runWithEcho helper in scripts/helpers.js that has the advantage that it prints output while the command is running instead of waiting for the end. You would need to turn the arguments into an array, though, but it should make for a better experience when developing locally.
Also, it promisifies the output, which means instead of a force exit, you can just top-level await the function so that errors will abort the script automatically with the full error.