allow manualChunks to be false #5054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so it can be overridden when vite merges configs this probably only affects me.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lukastaegert
reviewed
Jul 7, 2023
There was a problem hiding this comment.
I assume an explicit undefined would not work? The problem is, there is quite a bit more that needs to happen to add a new config value:
- adapt normalized options, or adapt the normalizer
- adapt documentation
- add a test
Also, false feels slightly off for this option. Would null also work? What problem is this actually solving? Is Vite generating manual chunks that you do not want? Wouldn't it make more sense to adapt/add an option on Vite side? After all, this fixes no problem inherent to Rollup but to a secondary tool.
Itzyboo1
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers: N/A
Description
allow manualChunks to be false so it can be overridden when configs are merged. this probably only affects me.