Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #4887

Merged
merged 4 commits into from
Mar 1, 2023
Merged

Refactor #4887

merged 4 commits into from
Mar 1, 2023

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Mar 1, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for rollupjs ready!

Name Link
🔨 Latest commit 65b815e
🔍 Latest deploy log https://app.netlify.com/sites/rollupjs/deploys/63ff98438f06c700086bfdf3
😎 Deploy Preview https://deploy-preview-4887--rollupjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #4887 (65b815e) into master (96f2eb1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
- Coverage   98.98%   98.98%   -0.01%     
==========================================
  Files         219      219              
  Lines        7970     7968       -2     
  Branches     2194     2194              
==========================================
- Hits         7889     7887       -2     
  Misses         26       26              
  Partials       55       55              
Impacted Files Coverage Δ
src/utils/renderChunks.ts 99.09% <100.00%> (-0.02%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dnalborczyk dnalborczyk marked this pull request as ready for review March 1, 2023 03:47
@lukastaegert lukastaegert enabled auto-merge (squash) March 1, 2023 18:26
@lukastaegert lukastaegert merged commit 25bdc12 into rollup:master Mar 1, 2023
@dnalborczyk dnalborczyk deleted the refactor branch March 1, 2023 18:41
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.18.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants