feat: mark files in a node_modules as ignore-listed by default

[bmeurer]

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

#4847

Description

Following up on the addition of the sourcemapIgnoreList output option, this adds a default which marks all files within a node_modules folder as ignore-listed. This way most projects using rollup will need no additional configuration regarding the ignore-listing and automatically benefit.

Doc: https://goo.gle/devtools-ignoreList-adoption

[netlify]

✅ Deploy Preview for rollupjs ready!

Name	Link
🔨 Latest commit	ca3eba9
🔍 Latest deploy log	https://app.netlify.com/sites/rollupjs/deploys/63ff942e05ef760008f68c18
😎 Deploy Preview	https://deploy-preview-4877--rollupjs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[codecov]

Codecov Report

Merging #4877 (ca3eba9) into master (1ab9833) will increase coverage by 0.00%.
The diff coverage is 91.66%.

@@           Coverage Diff           @@
##           master    #4877   +/-   ##
=======================================
  Coverage   98.98%   98.98%           
=======================================
  Files         219      219           
  Lines        7948     7951    +3     
  Branches     2189     2190    +1     
=======================================
+ Hits         7867     7870    +3     
  Misses         26       26           
  Partials       55       55           

Impacted Files	Coverage Δ
src/utils/renderChunks.ts	99.10% <87.50%> (-0.01%)	⬇️
src/utils/options/normalizeOutputOptions.ts	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[lukastaegert]

Thank you!

While I approve the change in general, now the only way to switch it off is to pass a function that always returns false.
I think we should adjust the types and handling slightly:

• E.g. allow an explicit false to turn off the feature. That would be consistent with how this works for other options like treeshake or watch
• Either translate false to an "always false" predicate and have always a function in the normalizedOutputOptions, or hand through the false value. I am slightly leaning to the former approach of always having a function for simplicity. In that case, we can remove the conditional logic in renderChunks that is currently not covered.

And of course, documentation should be adapted to show the new types and explain the default logic.

[bmeurer]

Thank you!

While I approve the change in general, now the only way to switch it off is to pass a function that always returns false. I think we should adjust the types and handling slightly:

• E.g. allow an explicit false to turn off the feature. That would be consistent with how this works for other options like treeshake or watch
• Either translate false to an "always false" predicate and have always a function in the normalizedOutputOptions, or hand through the false value. I am slightly leaning to the former approach of always having a function for simplicity. In that case, we can remove the conditional logic in renderChunks that is currently not covered.

And of course, documentation should be adapted to show the new types and explain the default logic.

Done, thanks!

[rollup-bot]

This PR has been released as part of rollup@3.18.0. You can test it via npm install rollup.