Include side effects of re-exporters unless they have no moduleSideEffects #4867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rollupjs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lukastaegert
force-pushed
the
module-side-effects-reexport
branch
from
34f3894
to
f8b30c4
Compare
This was referenced Feb 19, 2023
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#module-side-effects-reexportor load it into the REPL: |
This was referenced Feb 19, 2023
Codecov Report
@@ Coverage Diff @@
## master #4867 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 219 219
Lines 7943 7945 +2
Branches 2188 2189 +1
=======================================
+ Hits 7862 7864 +2
Misses 26 26
Partials 55 55
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This PR has been released as part of rollup@3.17.2. You can test it via |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
sideEffects#4470sideEffectsdoesn't seem to be working correctly vitejs/vite#7635sideEffectsplugins#1159Description
If a module with
moduleSideEffects:falseis reexporting from a module withmoduleSideEffects:truethat again is reexporting from another file, currently neither side effects in the first reexporter nor in the second reexporter are included.As this defeats expectations of many, this PR changes the logic so that in this case, side effects of the reexporter with
moduleSideEffects:trueARE indeed included, hopefully solving the issues that many people had.Note that as before, side effects are always included if the module does not use a reexport but rather imports the value and then directly exports it, independent of the
moduleSideEffectsvalue.