-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add needsCodeReference field to EmittedAsset #4805
feat: add needsCodeReference field to EmittedAsset #4805
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4805 +/- ##
=======================================
Coverage 98.98% 98.99%
=======================================
Files 219 219
Lines 7814 7826 +12
Branches 2166 2169 +3
=======================================
+ Hits 7735 7747 +12
Misses 26 26
Partials 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think this is a good solution for now. I have one minor refactoring suggestion. We should explain this in the docs, but I can also write a few lines later. Definitely at https://rollupjs.org/guide/en/#thisemitfile and probably also at https://rollupjs.org/guide/en/#file-urls
I updated relevant docs, if some information is incorrect (include English grammar or vocabulary), please feel free to correct it. |
6043eca
to
b68433b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! The examples are very good, I slightly tweaked the wording.
Thanks for your help too! |
This PR has been released as part of rollup@3.11.0. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
resolves #4774
Description