Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add needsCodeReference field to EmittedAsset #4805

Merged
merged 9 commits into from
Jan 26, 2023

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jan 17, 2023

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #4774

Description

@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #4805 (47b3d80) into master (3b560f7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4805   +/-   ##
=======================================
  Coverage   98.98%   98.99%           
=======================================
  Files         219      219           
  Lines        7814     7826   +12     
  Branches     2166     2169    +3     
=======================================
+ Hits         7735     7747   +12     
  Misses         26       26           
  Partials       53       53           
Impacted Files Coverage Δ
src/utils/FileEmitter.ts 100.00% <ø> (ø)
src/Bundle.ts 100.00% <100.00%> (ø)
src/utils/outputBundle.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think this is a good solution for now. I have one minor refactoring suggestion. We should explain this in the docs, but I can also write a few lines later. Definitely at https://rollupjs.org/guide/en/#thisemitfile and probably also at https://rollupjs.org/guide/en/#file-urls

src/Bundle.ts Outdated Show resolved Hide resolved
@TrickyPi
Copy link
Member Author

TrickyPi commented Jan 21, 2023

I updated relevant docs, if some information is incorrect (include English grammar or vocabulary), please feel free to correct it.

@rollup rollup deleted a comment from netlify bot Jan 26, 2023
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The examples are very good, I slightly tweaked the wording.

@lukastaegert lukastaegert enabled auto-merge (squash) January 26, 2023 07:55
@TrickyPi
Copy link
Member Author

Thanks for your help too!

@lukastaegert lukastaegert merged commit 29dd9dc into rollup:master Jan 26, 2023
@rollup-bot
Copy link
Collaborator

This PR has been released as part of rollup@3.11.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Add flag when emitting assets to not emit files that are not referenced in the output
4 participants