feat: add option to keep extensions for amd

cli/help.md

@@ -23,6 +23,7 @@ Basic options:
 --amd.autoId                Generate the AMD ID based off the chunk name
 --amd.basePath <prefix>     Path to prepend to auto generated AMD ID
 --amd.define <name>         Function to use in place of `define`
+--amd.keepExtension         Add `.js` extension for generated chunks and local AMD modules
 --assetFileNames <pattern>  Name pattern for emitted assets
 --banner <text>             Code to insert at top of bundle (outside wrapper)
 --chunkFileNames <pattern>  Name pattern for emitted secondary chunks

docs/01-command-line-reference.md

@@ -358,6 +358,7 @@ Many options have command line equivalents. In those cases, any arguments passed
 --amd.autoId                Generate the AMD ID based off the chunk name
 --amd.basePath <prefix>     Path to prepend to auto generated AMD ID
 --amd.define <name>         Function to use in place of `define`
+--amd.keepExtension         Add `.js` extension for generated chunks and local AMD modules
 --assetFileNames <pattern>  Name pattern for emitted assets
 --banner <text>             Code to insert at top of bundle (outside wrapper)
 --chunkFileNames <pattern>  Name pattern for emitted secondary chunks

docs/999-big-list-of-options.md

@@ -1331,6 +1331,23 @@ export default {
 // -> def(['dependency'],...
 ```
 
+**output.amd.keepExtension**<br> Type: `boolean`<br> CLI: `--amd.keepExtension`<br> Default: `false`
+
+Add `.js` extension for generated chunks and local AMD modules:
+
+```js
+// rollup.config.js
+export default {
+  ...,
+  format: 'amd',
+  amd: {
+    keepExtension: true
+  }
+};
+
+// -> define(['./chunk-or-local-file.js', 'dependency', 'third/dependency'],...
+```
+
 #### output.esModule
 
 Type: `boolean`<br> CLI: `--esModule`/`--no-esModule`<br> Default: `true`

src/Chunk.ts

@@ -938,7 +938,7 @@ export default class Chunk {
 		options: NormalizedOutputOptions,
 		snippets: GenerateCodeSnippets
 	): void {
-		const stripKnownJsExtensions = options.format === 'amd';
+		const stripKnownJsExtensions = options.format === 'amd' && !options.amd.keepExtension;
 		for (const [module, code] of this.renderedModuleSources) {
 			for (const { node, resolution } of module.dynamicImports) {
 				const chunk = this.chunkByModule.get(resolution as Module);

src/finalisers/amd.ts

@@ -3,7 +3,7 @@ import type { NormalizedOutputOptions } from '../rollup/types';
 import getCompleteAmdId from './shared/getCompleteAmdId';
 import { getExportBlock, getNamespaceMarkers } from './shared/getExportBlock';
 import getInteropBlock from './shared/getInteropBlock';
-import removeExtensionFromRelativeAmdId from './shared/removeExtensionFromRelativeAmdId';
+import updateExtensionForRelativeAmdId from './shared/updateExtensionForRelativeAmdId';
 import warnOnBuiltins from './shared/warnOnBuiltins';
 import type { FinaliserOptions } from './index';
 
@@ -35,7 +35,9 @@ export default function amd(
 	}: NormalizedOutputOptions
 ): Bundle {
 	warnOnBuiltins(warn, dependencies);
-	const deps = dependencies.map(m => `'${removeExtensionFromRelativeAmdId(m.id)}'`);
+	const deps = dependencies.map(
+		m => `'${updateExtensionForRelativeAmdId(m.id, amd.keepExtension)}'`
+	);
 	const args = dependencies.map(m => m.name);
 	const { n, getNonArrowFunctionIntro, _ } = snippets;
 

src/finalisers/shared/addJsExtension.ts

@@ -0,0 +1,3 @@
+export default function addJsExtension(name: string): string {
+	return !name.endsWith('.js') ? name + '.js' : name;
+}

src/finalisers/shared/updateExtensionForRelativeAmdId.ts

@@ -0,0 +1,16 @@
+import addJsExtension from './addJsExtension';
+import removeJsExtension from './removeJsExtension';
+
+// AMD resolution will only respect the AMD baseUrl if the .js extension is omitted.
+// The assumption is that this makes sense for all relative ids:
+// https://requirejs.org/docs/api.html#jsfiles
+export default function updateExtensionForRelativeAmdId(
+	id: string,
+	keepExtension: boolean
+): string {
+	if (id[0] !== '.') {
+		return id;
+	}
+
+	return keepExtension ? addJsExtension(id) : removeJsExtension(id);
+}

src/finalisers/umd.ts

@@ -5,10 +5,10 @@ import type { GenerateCodeSnippets } from '../utils/generateCodeSnippets';
 import getCompleteAmdId from './shared/getCompleteAmdId';
 import { getExportBlock, getNamespaceMarkers } from './shared/getExportBlock';
 import getInteropBlock from './shared/getInteropBlock';
-import removeExtensionFromRelativeAmdId from './shared/removeExtensionFromRelativeAmdId';
 import { keypath } from './shared/sanitize';
 import { assignToDeepVariable } from './shared/setupNamespace';
 import trimEmptyImports from './shared/trimEmptyImports';
+import updateExtensionForRelativeAmdId from './shared/updateExtensionForRelativeAmdId';
 import warnOnBuiltins from './shared/warnOnBuiltins';
 import type { FinaliserOptions } from './index';
 
@@ -73,7 +73,9 @@ export default function umd(
 
 	warnOnBuiltins(warn, dependencies);
 
-	const amdDeps = dependencies.map(m => `'${removeExtensionFromRelativeAmdId(m.id)}'`);
+	const amdDeps = dependencies.map(
+		m => `'${updateExtensionForRelativeAmdId(m.id, amd.keepExtension)}'`
+	);
 	const cjsDeps = dependencies.map(m => `require('${m.id}')`);
 
 	const trimmedImports = trimEmptyImports(dependencies);

src/rollup/types.d.ts

@@ -631,6 +631,8 @@ export type AmdOptions = (
 	  }
 ) & {
 	define?: string;
+} & {
+	keepExtension?: boolean;
 };
 
 export type NormalizedAmdOptions = (
@@ -644,6 +646,8 @@ export type NormalizedAmdOptions = (
 	  }
 ) & {
 	define: string;
+} & {
+	keepExtension: boolean;
 };
 
 export interface OutputOptions {

src/utils/options/normalizeOutputOptions.ts

@@ -225,10 +225,17 @@ const getPreserveModulesRoot = (
 };
 
 const getAmd = (config: OutputOptions): NormalizedOutputOptions['amd'] => {
-	const mergedOption: { autoId: boolean; basePath: string; define: string; id?: string } = {
+	const mergedOption: {
+		autoId: boolean;
+		basePath: string;
+		define: string;
+		id?: string;
+		keepExtension: boolean;
+	} = {
 		autoId: false,
 		basePath: '',
 		define: 'define',
+		keepExtension: false,
 		...config.amd
 	};
 
@@ -256,13 +263,15 @@ const getAmd = (config: OutputOptions): NormalizedOutputOptions['amd'] => {
 		normalized = {
 			autoId: true,
 			basePath: mergedOption.basePath,
-			define: mergedOption.define
+			define: mergedOption.define,
+			keepExtension: mergedOption.keepExtension
 		};
 	} else {
 		normalized = {
 			autoId: false,
 			define: mergedOption.define,
-			id: mergedOption.id
+			id: mergedOption.id,
+			keepExtension: mergedOption.keepExtension
 		};
 	}
 	return normalized;

test/form/samples/amd-keep-extension/_config.js

@@ -0,0 +1,7 @@
+module.exports = {
+	description: 'keep extension for AMD modules',
+	options: {
+		external: ['./foo', 'baz/quux'],
+		output: { interop: 'default', amd: { keepExtension: true } }
+	}
+};

test/form/samples/amd-keep-extension/_expected/amd.js

@@ -0,0 +1,7 @@
+define(['./foo.js', 'baz/quux'], (function (foo, baz) { 'use strict';
+
+	const bar = 42;
+
+	console.log(foo, bar, baz);
+
+}));

test/form/samples/amd-keep-extension/_expected/cjs.js

@@ -0,0 +1,8 @@
+'use strict';
+
+var foo = require('./foo');
+var baz = require('baz/quux');
+
+const bar = 42;
+
+console.log(foo, bar, baz);

test/form/samples/amd-keep-extension/_expected/es.js

@@ -0,0 +1,6 @@
+import foo from './foo';
+import baz from 'baz/quux';
+
+const bar = 42;
+
+console.log(foo, bar, baz);

test/form/samples/amd-keep-extension/_expected/iife.js

@@ -0,0 +1,8 @@
+(function (foo, baz) {
+	'use strict';
+
+	const bar = 42;
+
+	console.log(foo, bar, baz);
+
+})(foo, baz);

test/form/samples/amd-keep-extension/_expected/system.js

@@ -0,0 +1,18 @@
+System.register(['./foo', 'baz/quux'], (function () {
+	'use strict';
+	var foo, baz;
+	return {
+		setters: [function (module) {
+			foo = module["default"];
+		}, function (module) {
+			baz = module["default"];
+		}],
+		execute: (function () {
+
+			const bar = 42;
+
+			console.log(foo, bar, baz);
+
+		})
+	};
+}));

test/form/samples/amd-keep-extension/_expected/umd.js

@@ -0,0 +1,11 @@
+(function (global, factory) {
+	typeof exports === 'object' && typeof module !== 'undefined' ? factory(require('./foo'), require('baz/quux')) :
+	typeof define === 'function' && define.amd ? define(['./foo.js', 'baz/quux'], factory) :
+	(global = typeof globalThis !== 'undefined' ? globalThis : global || self, factory(global.foo, global.baz));
+})(this, (function (foo, baz) { 'use strict';
+
+	const bar = 42;
+
+	console.log(foo, bar, baz);
+
+}));

test/form/samples/amd-keep-extension/bar.js

@@ -0,0 +1 @@
+export const bar = 42;

test/form/samples/amd-keep-extension/main.js

@@ -0,0 +1,5 @@
+import foo from './foo';
+import { bar } from './bar';
+import baz from 'baz/quux';
+
+console.log(foo, bar, baz);

test/function/samples/output-options-hook/_config.js

@@ -18,7 +18,8 @@ module.exports = {
 				assert.deepStrictEqual(JSON.parse(JSON.stringify(options)), {
 					amd: {
 						define: 'define',
-						autoId: false
+						autoId: false,
+						keepExtension: false
 					},
 					assetFileNames: 'assets/[name]-[hash][extname]',
 					chunkFileNames: '[name]-[hash].js',