-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
chor(package.json): unlock dist in exports for programatical code reuse without patching rollup #4436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chor(package.json): unlock dist in exports for programatical code reuse without patching rollup #4436
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4436 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 205 205
Lines 7324 7324
Branches 2080 2080
=======================================
Hits 7234 7234
Misses 33 33
Partials 57 57 Continue to review full report at Codecov.
|
|
@lukastaegert ok so you think its better that i replicate the rollup source in my projects, or should i always make patches for rollup versions whats your opinion. And by the way for any other engine that does not care for package.json it is already exposed even as single module file if you want to produce none reuseable code maybe consider compiling some parts to binary or even v8 snapshots. Short versionmy main reason to reuse the existing code is that i can follow api changes fast and refactor fast when i maintain extra versions which i already do! it is extra none needed overhead. |
While the issue that leaded to this PR is solved i still think this should be merged it blocks people from doing what they wanna do if they use a instable API why not? whole TS tooling is build up on none exposed API's that are even more protected There is a whole community fork of Typescript only to expose the Instable API's coders should not block coders in a open source eco system while i understand your reasoning and it makes rollup really a good product do not get me wrong but there must be a middle way. |
Fun fact: Actually everything was meant to be exposed to have compatibility between Node 10 and later versions. In the "original" version of package.exports, |
@lukastaegert always a plesure to work with you |
Allow to import modules without extension from dist see: rollup#4436 (comment)
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
This PR allows to use all files in the dist folder if they get imported directly this is needed to allow custom builds and do some code reuse.
my current usecase is a file called:
rollup.build.js