Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove acorn-walk ambient type definitions #4391

Merged
merged 1 commit into from Feb 9, 2022

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Feb 8, 2022

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

base is defined in acorn-walk module

@dnalborczyk dnalborczyk changed the title chore: remove acorn-walk ambient type definitions refactor: remove acorn-walk ambient type definitions Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #4391 (0bc3bcc) into master (efd71e9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4391   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         204      204           
  Lines        7320     7320           
  Branches     2080     2080           
=======================================
  Hits         7227     7227           
  Misses         34       34           
  Partials       59       59           
Impacted Files Coverage Δ
src/utils/pureComments.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efd71e9...0bc3bcc. Read the comment docs.

@lukastaegert lukastaegert merged commit 903b464 into rollup:master Feb 9, 2022
@dnalborczyk dnalborczyk deleted the acorn-walk branch February 10, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants