Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make namespace @@toStringTag "Module" non-enumerable #4378

Merged
merged 13 commits into from Mar 2, 2022
Merged

Make namespace @@toStringTag "Module" non-enumerable #4378

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e38cfca
test: namespace export should have @@toStringTag with correct propert…
dnalborczyk Feb 2, 2022
d4c9223
add additional Object.assign and object spread test cases
dnalborczyk Feb 4, 2022
e468468
add more asserts
dnalborczyk Feb 4, 2022
3b11723
use deepStrictEqual
dnalborczyk Feb 6, 2022
15f136a
Merge branch 'master' into test/4336-to-string-tag
dnalborczyk Feb 6, 2022
98450e9
Make toStringTag non-enumerable for dynamic namespaces
lukastaegert Feb 27, 2022
1ac9546
Make toStringTag non-enumerable for interop namespaces
lukastaegert Feb 27, 2022
f827373
Do not freeze merged namespaces twice
lukastaegert Feb 27, 2022
9c9ff04
Generate toStringTag in merged namespaces
lukastaegert Feb 27, 2022
44535eb
Simplify output by defining properties together
lukastaegert Feb 28, 2022
43f95f7
Deprecate namespaceToStringTag in favour of generatedCode.symbols
lukastaegert Mar 1, 2022
c5fdd51
Merge branch 'master' into test/4336-to-string-tag
lukastaegert Mar 1, 2022
e2c395b
Deprecate namespaceToStringTag in favour of generatedCode.symbols
lukastaegert Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions test/function/samples/namespace-to-string-tag/_config.js
View file
Open in desktop
@@ -0,0 +1,8 @@
module.exports = {
description: 'namespace export should have @@toStringTag with correct property descriptors #4336',
options: {
output: {
namespaceToStringTag: true
}
}
};
1 change: 1 addition & 0 deletions test/function/samples/namespace-to-string-tag/foo.js
View file
Open in desktop
@@ -0,0 +1 @@
export const foo = 'bar';
11 changes: 11 additions & 0 deletions test/function/samples/namespace-to-string-tag/main.js
View file
Open in desktop
@@ -0,0 +1,11 @@
import * as ns from './foo.js';

const { configurable, enumerable, value, writable } = Object.getOwnPropertyDescriptor(
ns,
Symbol.toStringTag
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not explicitly check the Object.assign behaviour? Then this would also document why it is important and people do not need to Google it again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, I'll add that to the test.


assert.strictEqual(value, 'Module', 'value');
assert.strictEqual(configurable, false, 'configurable');
assert.strictEqual(enumerable, false, 'enumerable');
assert.strictEqual(writable, false, 'writable');