test: handles default export of anonymous class with correct name #4324 #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnalborczyk
force-pushed
the
test/4324-anonymous-class-export
branch
from
9be2287
to
bb142ba
Compare
| @@ -0,0 +1,3 @@ | |||
| import defaultClass from './foo.js'; | |||
|
|
|||
| assert.strictEqual('default', defaultClass.name); | |||
There was a problem hiding this comment.
Shouldn't the name be undefined?
There was a problem hiding this comment.
no, that's essentially the bug. a default exported anonymous class has the name default. you can try it out in node.js or in a browser.
There was a problem hiding this comment.
Indeed you are right. Funny quirk.
guybedford
reviewed
Feb 20, 2022
yeah, the idea is that as soon as someone finds the time to fix the issue the test can be pulled in as well. |
lukastaegert
force-pushed
the
master
branch
7 times, most recently
from
eca6a6c
to
71d20c9
Compare
lukastaegert
force-pushed
the
master
branch
3 times, most recently
from
cbd94e6
to
f1538ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
[failing] test case for 4324
is
test/function/samples/the correct bucket?