Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: even more types #4373

Merged
merged 5 commits into from Feb 5, 2022
Merged

fix: even more types #4373

merged 5 commits into from Feb 5, 2022

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #4373 (933514f) into master (e38dc61) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4373   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files         204      204           
  Lines        7315     7315           
  Branches     2082     2082           
=======================================
  Hits         7222     7222           
  Misses         34       34           
  Partials       59       59           
Impacted Files Coverage Δ
cli/cli.ts 71.42% <ø> (ø)
cli/run/batchWarnings.ts 99.19% <ø> (ø)
cli/run/build.ts 91.89% <ø> (ø)
cli/run/index.ts 100.00% <ø> (ø)
cli/run/loadConfigFromCommand.ts 100.00% <ø> (ø)
cli/run/stdin.ts 100.00% <ø> (ø)
cli/run/timings.ts 0.00% <ø> (ø)
src/ModuleLoader.ts 100.00% <ø> (ø)
src/ast/CallOptions.ts 100.00% <ø> (ø)
src/ast/ExecutionContext.ts 100.00% <ø> (ø)
... and 121 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e38dc61...933514f. Read the comment docs.

@dnalborczyk dnalborczyk changed the title fix: fix even more types fix: even more types Jan 29, 2022
@lukastaegert lukastaegert merged commit 56c1514 into rollup:master Feb 5, 2022
@dnalborczyk dnalborczyk deleted the types branch February 7, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants