Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fs.promises in module loader, Part 2 #4372

Merged
merged 2 commits into from Jan 30, 2022

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@dnalborczyk dnalborczyk marked this pull request as draft January 29, 2022 22:29
@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #4372 (4ef8a2a) into master (4611705) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4372      +/-   ##
==========================================
+ Coverage   98.70%   98.72%   +0.02%     
==========================================
  Files         205      205              
  Lines        7320     7311       -9     
  Branches     2083     2083              
==========================================
- Hits         7225     7218       -7     
+ Misses         35       34       -1     
+ Partials       60       59       -1     
Impacted Files Coverage Δ
src/ModuleLoader.ts 100.00% <100.00%> (ø)
src/utils/fs.ts 100.00% <100.00%> (+18.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4611705...4ef8a2a. Read the comment docs.

@dnalborczyk dnalborczyk changed the title refactor: use fs.promises in module loader refactor: use fs.promises in module loader, Part 2 Jan 29, 2022
@dnalborczyk dnalborczyk marked this pull request as ready for review January 29, 2022 23:01
@lukastaegert lukastaegert merged commit 50f46bc into rollup:master Jan 30, 2022
@dnalborczyk dnalborczyk deleted the fs-promises-part-2 branch January 30, 2022 16:34
@dnalborczyk dnalborczyk mentioned this pull request Feb 4, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants