Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use fs.promises in cli/run, Part 1 #4371

Merged
merged 1 commit into from Jan 30, 2022

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #4371 (de0b23a) into master (5364114) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4371   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files         205      205           
  Lines        7320     7320           
  Branches     2083     2083           
=======================================
  Hits         7225     7225           
  Misses         35       35           
  Partials       60       60           
Impacted Files Coverage Δ
cli/run/getConfigPath.ts 88.88% <100.00%> (ø)
cli/run/index.ts 100.00% <100.00%> (ø)
cli/run/loadConfigFile.ts 96.15% <100.00%> (ø)
cli/run/watch-cli.ts 89.70% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5364114...de0b23a. Read the comment docs.

@dnalborczyk dnalborczyk marked this pull request as draft January 29, 2022 17:29
@dnalborczyk dnalborczyk changed the title refactor: use fs.promises in cli/run refactor: use fs.promises in cli/run, Part 1 Jan 29, 2022
@dnalborczyk dnalborczyk marked this pull request as ready for review January 29, 2022 23:01
@lukastaegert lukastaegert merged commit 4611705 into rollup:master Jan 30, 2022
@dnalborczyk dnalborczyk deleted the fs-promises-part-1 branch January 30, 2022 16:33
@dnalborczyk dnalborczyk mentioned this pull request Feb 4, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants