Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Array.prototype.groupBy/groupByToMap #4360

Merged
merged 3 commits into from Jan 29, 2022
Merged

feat: add Array.prototype.groupBy/groupByToMap #4360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab4ae35
feat: add Array.prototype.groupBy/groupByToMap
dnalborczyk Jan 22, 2022
0d178aa
Merge branch 'master' into array-grouping
dnalborczyk Jan 28, 2022
c9f5dfb
Merge branch 'master' into array-grouping
lukastaegert Jan 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ast/nodes/shared/ArrayPrototype.ts
View file
Open in desktop
Expand Up @@ -133,6 +133,8 @@ export const ARRAY_PROTOTYPE = new ObjectEntity(
flat: METHOD_DEOPTS_SELF_RETURNS_NEW_ARRAY,
flatMap: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_NEW_ARRAY,
forEach: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_UNKNOWN,
groupBy: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_UNKNOWN,
groupByToMap: METHOD_CALLS_ARG_DEOPTS_SELF_RETURNS_UNKNOWN,
includes: METHOD_RETURNS_BOOLEAN,
indexOf: METHOD_RETURNS_NUMBER,
join: METHOD_RETURNS_STRING,
Expand Down
8 changes: 8 additions & 0 deletions test/form/samples/builtin-prototypes/array-expression/_expected.js
View file
Open in desktop
Expand Up @@ -55,6 +55,14 @@ _flatMapArray[0].effect();
const _forEachArray = [{ effect() {} }];
_forEachArray.forEach(element => (element.effect = () => console.log(1)));
_forEachArray[0].effect();
[1].groupBy(() => console.log(1) || true);
const _groupByArray = [{ effect() {} }];
_groupByArray.groupBy((_, element) => (element.effect = () => console.log(1)));
_groupByArray[0].effect();
[1].groupByToMap(() => console.log(1) || true);
const _groupByToMapArray = [{ effect() {} }];
_groupByToMapArray.groupBy((_, element) => (element.effect = () => console.log(1)));
_groupByToMapArray[0].effect();
[1].map(() => console.log(1) || 1);
const _mapArray = [{ effect() {} }];
_mapArray.map(element => (element.effect = () => console.log(1)));
Expand Down
12 changes: 12 additions & 0 deletions test/form/samples/builtin-prototypes/array-expression/main.js
View file
Open in desktop
Expand Up @@ -104,6 +104,18 @@ const _forEachArray = [{ effect() {} }];
_forEachArray.forEach(element => (element.effect = () => console.log(1)));
_forEachArray[0].effect();

const _groupBy = [1].groupBy(() => true);
const _groupByEffect = [1].groupBy(() => console.log(1) || true);
const _groupByArray = [{ effect() {} }];
_groupByArray.groupBy((_, element) => (element.effect = () => console.log(1)));
_groupByArray[0].effect();

const _groupByToMap = [1].groupByToMap(() => true);
const _groupByToMapEffect = [1].groupByToMap(() => console.log(1) || true);
const _groupByToMapArray = [{ effect() {} }];
_groupByToMapArray.groupBy((_, element) => (element.effect = () => console.log(1)));
_groupByToMapArray[0].effect();

const _map = [1].map(() => 1).join(',');
const _mapEffect = [1].map(() => console.log(1) || 1);
const _mapArray = [{ effect() {} }];
Expand Down