Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly restart Rollup when config file change is detected #4344

Merged
merged 10 commits into from Jan 14, 2022
Merged

Directly restart Rollup when config file change is detected #4344

merged 10 commits into from Jan 14, 2022

Commits on Jan 14, 2022

  1. Improve test reliability

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    d00911d View commit details
    Browse the repository at this point in the history

  2. Increase timeout and repeat

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    9b289ab View commit details
    Browse the repository at this point in the history

  3. Try again with a watcher

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    43f377c View commit details
    Browse the repository at this point in the history

  4. Try using fs.watchfile in the config

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    f087144 View commit details
    Browse the repository at this point in the history

  5. Wait a little after initial config write

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    898b94b View commit details
    Browse the repository at this point in the history

  6. Limit how long we wait at most

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    88aa452 View commit details
    Browse the repository at this point in the history

  7. Immediately restart Rollup upon config file changes 

    and change test to look for a message from the second config
    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    baa6773 View commit details
    Browse the repository at this point in the history

  8. See if we can trigger a stuck watcher by writing again

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    8e8b2a1 View commit details
    Browse the repository at this point in the history

  9. Extract retry helper

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    d06de28 View commit details
    Browse the repository at this point in the history

  10. Clean up

    @lukastaegert
    lukastaegert committed Jan 14, 2022
    Copy the full SHA
    8f85dfa View commit details
    Browse the repository at this point in the history