Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert rollup commonjs plugin to v20 #4308

Closed
wants to merge 1 commit into from

Conversation

dnalborczyk
Copy link
Contributor

@dnalborczyk dnalborczyk commented Dec 17, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

temporary "fixes": #4300 (comment)

/cc @kzc

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #4308 (ce1c8fb) into master (28cc198) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4308      +/-   ##
==========================================
- Coverage   98.45%   98.42%   -0.03%     
==========================================
  Files         205      205              
  Lines        7311     7313       +2     
  Branches     2082     2083       +1     
==========================================
  Hits         7198     7198              
- Misses         55       56       +1     
- Partials       58       59       +1     
Impacted Files Coverage Δ
src/watch/fsevents-importer.ts 50.00% <0.00%> (-25.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28cc198...ce1c8fb. Read the comment docs.

@kzc kzc mentioned this pull request Dec 17, 2021
9 tasks
@kzc
Copy link
Contributor

kzc commented Dec 17, 2021

A mocha test should be added to confirm the existence of the functions in #4300 (comment).

@kzc
Copy link
Contributor

kzc commented Dec 18, 2021

Although this PR would avoid random watch test failures on Mac, it appears that the problem is more nuanced than I first thought - see #4300 (comment).

@dnalborczyk
Copy link
Contributor Author

superseded by: #4312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants