Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support query parameters and fragments #4279

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

dnalborczyk
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #4279 (8fdf7d4) into master (8d98341) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4279      +/-   ##
==========================================
- Coverage   98.39%   98.39%   -0.01%     
==========================================
  Files         204      204              
  Lines        7312     7307       -5     
  Branches     2084     2083       -1     
==========================================
- Hits         7195     7190       -5     
  Misses         58       58              
  Partials       59       59              
Impacted Files Coverage Δ
src/utils/path.ts 66.66% <0.00%> (ø)
src/utils/resolveId.ts 93.33% <75.00%> (-1.41%) ⬇️
src/ModuleLoader.ts 100.00% <100.00%> (ø)
src/utils/fs.ts 75.00% <100.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d98341...8fdf7d4. Read the comment docs.

@dnalborczyk dnalborczyk changed the title strip query params and hash from file feat: support query parameters and fragments Nov 22, 2021
@kzc
Copy link
Contributor

kzc commented Nov 23, 2021

Not sure what core rollup changes will be made in this PR at this early stage, but be sure to test it with https://github.com/mjackson/rollup-plugin-url-resolve as it already handles http:/https: URL query parameters and fragments. Sample usage: #4275 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants