Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more TaggedTemplateExpression treeshake support #4277

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

LongTengDao
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #3880

Description

@LongTengDao LongTengDao changed the title support TaggedTemplateExpression in markPureNode more TaggedTemplateExpression treeshake support Nov 19, 2021
@LongTengDao LongTengDao reopened this Nov 19, 2021
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #4277 (dfba1e3) into master (8d98341) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4277   +/-   ##
=======================================
  Coverage   98.39%   98.40%           
=======================================
  Files         204      204           
  Lines        7312     7319    +7     
  Branches     2084     2088    +4     
=======================================
+ Hits         7195     7202    +7     
  Misses         58       58           
  Partials       59       59           
Impacted Files Coverage Δ
src/utils/pureComments.ts 100.00% <ø> (ø)
src/ast/nodes/TaggedTemplateExpression.ts 100.00% <100.00%> (ø)
src/ast/nodes/NodeType.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d98341...dfba1e3. Read the comment docs.

@lukastaegert
Copy link
Member

Hi, sorry for the silence. I know I said to go ahead, but I had completely forgotten this discussion: #4035
While I think such an annotation would be useful, it is ultimately Uglify's annotation so we should probably stick with what they do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

__PURE__ is not work with template
2 participants