Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use entryFileNames when generating filenames for virtual modules #4270

Merged
merged 4 commits into from Nov 22, 2021

Commits on Nov 14, 2021

  1. Copy the full SHA
    e67174e View commit details
    Browse the repository at this point in the history
  2. Fix existing tests

    - virtual files now have a .js extension by default
    - systemjs module references include this file extension
    - amd module references omit this file extension. this seems to be
      consistent with amd output of other chunks
    BPScott committed Nov 14, 2021
    Copy the full SHA
    8c5030d View commit details
    Browse the repository at this point in the history
  3. Add new test for virtual file output when modifying entryFileNames

    Use entryFileNames to change the extension of the filename to be mjs,
    and see that the file created from the virtual file chunk has a .mjs
    extension
    
    Note that the amd definition contains the .mjs extension, as amd ids only
    strip the .js file extension, which is slightly odd but probably ok as
    this amd is not the targetted usecase for this behaviour
    BPScott committed Nov 14, 2021
    Copy the full SHA
    8f3747b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Copy the full SHA
    9d36805 View commit details
    Browse the repository at this point in the history