Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused rollup-plugin-typescript ambient module types #4233

Merged
merged 3 commits into from Oct 1, 2021
Merged

chore: remove unused rollup-plugin-typescript ambient module types #4233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc3dbec
chore: remove unused rollup-plugin-typescript ambient module types
dnalborczyk Sep 29, 2021
d55b0cd
chore: fix return type of is_reference
dnalborczyk Sep 29, 2021
6a9e41e
chore: remove type assertion
dnalborczyk Sep 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ast/nodes/Identifier.ts
View file
Open in desktop
Expand Up @@ -45,7 +45,7 @@ export default class Identifier extends NodeBase implements PatternNode {
}

bind(): void {
if (this.variable === null && isReference(this, this.parent as any)) {
if (this.variable === null && isReference(this, this.parent)) {
this.variable = this.scope.findVariable(this.name);
this.variable.addReference(this);
}
Expand Down
7 changes: 1 addition & 6 deletions typings/declarations.d.ts
View file
Open in desktop
Expand Up @@ -9,11 +9,6 @@ declare module 'rollup-plugin-string' {
export const string: import('rollup').PluginImpl;
}

declare module 'rollup-plugin-typescript' {
const typescript: import('rollup').PluginImpl;
export default typescript;
}

declare module 'acorn-walk' {
type WalkerCallback<TState> = (node: acorn.Node, state: TState) => void;
type RecursiveWalkerFn<TState> = (
Expand All @@ -29,7 +24,7 @@ declare module 'is-reference' {
export default function is_reference(
node: NodeWithFieldDefinition,
parent: NodeWithFieldDefinition
): unknown;
): boolean;
export type Node =
| import('estree').Identifier
| import('estree').SimpleLiteral
Expand Down