Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent UnhandledPromiseRejectionWarning when module resolution/parsing fails #4228

Merged
merged 2 commits into from Sep 18, 2021
Merged

fix: prevent UnhandledPromiseRejectionWarning when module resolution/parsing fails #4228

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
659a12f
fix: prevent UnhandledPromiseRejectionWarning from module resolution/…
kherock Sep 13, 2021
ce1cd4d
Account for changed Node 16 error messages
lukastaegert Sep 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/ModuleLoader.ts
View file
Open in desktop
Expand Up @@ -341,7 +341,12 @@ export class ModuleLoader {
Promise.all([
...(resolveStaticDependencyPromises as Promise<never>[]),
...(resolveDynamicImportPromises as Promise<never>[])
]).then(() => this.pluginDriver.hookParallel('moduleParsed', [module.info]));
]).then(
() => this.pluginDriver.hookParallel('moduleParsed', [module.info]),
() => {
/* rejections thrown here are also handled within PluginDriver - they are safe to ignore */
}
);
await Promise.all([
this.fetchStaticDependencies(module, resolveStaticDependencyPromises),
this.fetchDynamicDependencies(module, resolveDynamicImportPromises)
Expand Down