Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use colorette instead of turbocolor #3391 #4114

Merged
merged 1 commit into from May 30, 2021

Conversation

ryuever
Copy link
Contributor

@ryuever ryuever commented May 29, 2021

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

turbocolor has been replaced with colorette in #3391, for now it is still used in perf.js file

@github-actions
Copy link

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install ryuever/rollup#fix-colorette

or load it into the REPL:
https://rollupjs.org/repl/?pr=4114

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@codecov
Copy link

codecov bot commented May 30, 2021

Codecov Report

Merging #4114 (8ea05d2) into master (184eb60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4114   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files         201      201           
  Lines        7061     7061           
  Branches     2064     2064           
=======================================
  Hits         6928     6928           
  Misses         64       64           
  Partials       69       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184eb60...8ea05d2. Read the comment docs.

@lukastaegert lukastaegert merged commit e42e528 into rollup:master May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants