Prevent crash for recursive "this" deoptimization #4091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-4089-recursive-this-deoptimizationor load it into the REPL: |
Codecov Report
@@ Coverage Diff @@
## master #4091 +/- ##
=======================================
Coverage 98.01% 98.01%
=======================================
Files 201 201
Lines 6992 6994 +2
Branches 2053 2054 +1
=======================================
+ Hits 6853 6855 +2
Misses 66 66
Partials 73 73
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #4089
Description
Apparently there are scenarios where deoptimizing "this" in a method could lead to an infinite loop, terminated by an out-of-memory error. This is fixed here by tracking which deoptimizations already happened.