feat: add support for private class methods

[dnalborczyk]

add support for private methods: https://github.com/tc39/proposal-private-methods

REPL

This PR contains:

• bugfix
• feature
• refactor
• documentation
• other

Are tests included?

• yes (bugfixes and features will not be merged without tests)
• no

Breaking Changes?

• yes (breaking changes will not be merged unless absolutely necessary)
• no

List any relevant issue numbers:

Description

[github-actions]

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install dnalborczyk/rollup#private-methods

Once a build has completed, you can load it into the REPL by inserting the CircleCI build number of the ci/circleci: node-v12-latest build into the link below (unfortunately, we cannot auto-update this comment for PRs from forks at this time):

https://rollupjs.org/repl/?circleci=<build_number>

[codecov]

Codecov Report

Merging #4034 (5ae5dfb) into master (dba6f13) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4034   +/-   ##
=======================================
  Coverage   97.47%   97.47%           
=======================================
  Files         192      192           
  Lines        6785     6785           
  Branches     1994     1994           
=======================================
  Hits         6614     6614           
  Misses         84       84           
  Partials       87       87           

Impacted Files	Coverage Δ
src/utils/options/normalizeInputOptions.ts	100.00% <ø> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dba6f13...5ae5dfb. Read the comment docs.

[dnalborczyk]

ci on windows seems to have an issue:

npm ERR! Error while executing:
npm ERR! C:\Program Files\Git\bin\git.EXE ls-remote -h -t ssh://git@github.com/lukastaegert/is-reference.git
npm ERR! 
npm ERR! Host key verification failed.
npm ERR! fatal: Could not read from remote repository.
npm ERR! 
npm ERR! Please make sure you have the correct access rights
npm ERR! and the repository exists.
npm ERR! 
npm ERR! exited with error code: 128

[lukastaegert]

I assume you are not using SSH to access Github? That could explain the test issues. Will see if we can change something on our side to improve here.

[dnalborczyk]

I assume you are not using SSH to access Github? That could explain the test issues. Will see if we can change something on our side to improve here.

sorry, I was referring to the windows ci run: https://github.com/rollup/rollup/runs/2273299082 not any local runs (I'm using a mac).

my local git settings wouldn't have any effect on how the ci pulls the dependency repo? 🤔

[lukastaegert]

Probably not. Still I wonder why it could not fetch the dependency via SSH, my though is that it was using some settings from your fork, but then again, it is very weird. Others doing that did not have this issue. In any case, I fixed it by changing the dependency to force HTTPS instead of SSH, this should always work.

[lukastaegert]

Very nice, and glad you could finally remove the comments from the test cases!

[jef]

Did it have anything to do with the way npm 7 vs npm 6 worked in pulling the dependencies? I see the package-lock changed between the two as well.

[lukastaegert]

Possible. For now I did not dare updating the lock file. But more importantly, the original lock file contained an ssh references while the new one uses https for the is_references package.

[dnalborczyk]

But more importantly, the original lock file contained an ssh references while the new one uses https for the is_references package.

ah, I see, that was the issue then! yeah, I was using node.js v15+ w/ npm 7+. forgot the fact that they updated the package-lock format (v2).

thank you for looking into this @jef !

thank you for reviewing and pulling in the PR @lukastaegert !