New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable pessimistic object deoptimization for calls when the called function doesn't ref this #4011
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b0eb271
Disable pessimistic object deoptimization for calls when the called f…
marijnh 41b3453
Use a base class for special-purpose value objects
marijnh e9cb664
Remove toString for values
lukastaegert 12792eb
Move function Node initialization to parseNode
lukastaegert 4214087
Also handle arrow functions
lukastaegert 8ad9bd7
Merge branch 'master' into master
lukastaegert File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,12 +16,16 @@ export default class FunctionNode extends NodeBase { | |
id!: IdentifierWithVariable | null; | ||
params!: PatternNode[]; | ||
preventChildBlockScope!: true; | ||
referencesThis!: boolean; | ||
scope!: FunctionScope; | ||
|
||
private isPrototypeDeoptimized = false; | ||
|
||
createScope(parentScope: FunctionScope) { | ||
this.scope = new FunctionScope(parentScope, this.context); | ||
// Initialized here because child nodes will update it before | ||
// `this.initialize` even runs. | ||
this.referencesThis = false; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah I see. Maybe move it rather into |
||
} | ||
|
||
deoptimizePath(path: ObjectPath) { | ||
|
@@ -120,6 +124,12 @@ export default class FunctionNode extends NodeBase { | |
this.body.addImplicitReturnExpressionToScope(); | ||
} | ||
|
||
mayModifyThisWhenCalledAtPath( | ||
path: ObjectPath | ||
) { | ||
return path.length ? true : this.referencesThis | ||
} | ||
|
||
parseNode(esTreeNode: GenericEsTreeNode) { | ||
this.body = new this.context.nodeConstructors.BlockStatement( | ||
esTreeNode.body, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like this use of a for loop.