New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap simplified assignments if necessary #3951
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,22 @@ | ||
import MagicString from 'magic-string'; | ||
import { BLANK } from '../../utils/blank'; | ||
import { NodeRenderOptions, RenderOptions } from '../../utils/renderHelpers'; | ||
import * as NodeType from './NodeType'; | ||
import ClassNode from './shared/ClassNode'; | ||
|
||
export default class ClassExpression extends ClassNode { | ||
type!: NodeType.tClassExpression; | ||
|
||
render( | ||
code: MagicString, | ||
options: RenderOptions, | ||
{ renderedParentType, renderedSurroundingElement }: NodeRenderOptions = BLANK | ||
) { | ||
super.render(code, options); | ||
const surroundingElement = renderedParentType || renderedSurroundingElement; | ||
if (surroundingElement === NodeType.ExpressionStatement) { | ||
code.appendRight(this.start, '('); | ||
code.prependLeft(this.end, ')'); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,22 @@ | ||
import MagicString from 'magic-string'; | ||
import { BLANK } from '../../utils/blank'; | ||
import { NodeRenderOptions, RenderOptions } from '../../utils/renderHelpers'; | ||
import * as NodeType from './NodeType'; | ||
import FunctionNode from './shared/FunctionNode'; | ||
|
||
export default class FunctionExpression extends FunctionNode { | ||
type!: NodeType.tFunctionExpression; | ||
|
||
render( | ||
code: MagicString, | ||
options: RenderOptions, | ||
{ renderedParentType, renderedSurroundingElement }: NodeRenderOptions = BLANK | ||
) { | ||
super.render(code, options); | ||
const surroundingElement = renderedParentType || renderedSurroundingElement; | ||
if (surroundingElement === NodeType.ExpressionStatement) { | ||
code.appendRight(this.start, '('); | ||
code.prependLeft(this.end, ')'); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/chunking-form/samples/namespace-reexports/_expected/es/hsl2hsv.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...en-dynamic-hash/_expected/amd/19d89d54.js → ...en-dynamic-hash/_expected/amd/16d985e6.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
define(function () { 'use strict'; | ||
|
||
var main = null; | ||
var main = null; | ||
|
||
return main; | ||
|
||
|
2 changes: 1 addition & 1 deletion
2
...en-dynamic-hash/_expected/cjs/797a17bf.js → ...en-dynamic-hash/_expected/cjs/05ff8838.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
'use strict'; | ||
|
||
var main = null; | ||
var main = null; | ||
|
||
module.exports = main; |
2 changes: 1 addition & 1 deletion
2
...ken-dynamic-hash/_expected/es/114f0e8d.js → ...ken-dynamic-hash/_expected/es/bed29d35.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
var main = null; | ||
var main = null; | ||
|
||
export default main; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
test/form/samples/break-control-flow/break-statement-labels-in-loops/_expected.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
while (globalThis.unknown) { | ||
console.log('retained'); | ||
{ | ||
{ | ||
break; | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 8 additions & 8 deletions
16
test/form/samples/builtin-prototypes/object-expression/_expected.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
const object = {}; | ||
object.propertyIsEnumerable( 'toString' ); | ||
{}.propertyIsEnumerable( 'toString' ); | ||
{}.propertyIsEnumerable( 'toString' ).valueOf(); | ||
({}).propertyIsEnumerable( 'toString' ); | ||
({}).propertyIsEnumerable( 'toString' ).valueOf(); | ||
|
||
{}.hasOwnProperty( 'toString' ).valueOf(); | ||
{}.isPrototypeOf( {} ).valueOf(); | ||
{}.propertyIsEnumerable( 'toString' ).valueOf(); | ||
{}.toLocaleString().trim(); | ||
{}.toString().trim(); | ||
{}.valueOf(); | ||
({}).hasOwnProperty( 'toString' ).valueOf(); | ||
({}).isPrototypeOf( {} ).valueOf(); | ||
({}).propertyIsEnumerable( 'toString' ).valueOf(); | ||
({}).toLocaleString().trim(); | ||
({}).toString().trim(); | ||
({}).valueOf(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lukastaegert If all test output is reparsed with acorn in the test framework then issues like this one could be caught earlier in the future. Please ignore if this PR already implemented this suggestion, but I did not see it.
For example, using the previous version of this file:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With 574050b: