New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to add a windows executor #3889
Conversation
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via
or load it into the REPL: |
4b91f26
to
645bc99
Compare
@lukastaegert we don't have any issues with Github actions running for forks in the plugins repo. Can you point me to a PR here that got messed up for a fork? |
Any PR from an account that does not itself have Github actions enabled. #3841 was the last one that had me scrambling to fix tests directly on master after merging the PR. As for an upcoming PR, you can see that #3883 does not have the Windows checks running either. Unless Github changes their policy to also run Github actions for PRs from forks that do not have themselves Github actions enabled, I am seriously looking for alternatives here. |
Seems to work now with Github Actions, so I will close this PR. If we are happy, maybe at some point we can consider moving entirely to Github Actions on the other hand. |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
As Github actions tend to not run for PRs from forks, I am investigating here if we can use a Windows executor for CircleCI