Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to add a windows executor #3889

Closed
wants to merge 8 commits into from
Closed

Try to add a windows executor #3889

wants to merge 8 commits into from

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

As Github actions tend to not run for PRs from forks, I am investigating here if we can use a Windows executor for CircleCI

@rollup-bot
Copy link
Collaborator

rollup-bot commented Nov 30, 2020

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#circleci-windows

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13715

@shellscape
Copy link
Contributor

@lukastaegert we don't have any issues with Github actions running for forks in the plugins repo. Can you point me to a PR here that got messed up for a fork?

@lukastaegert
Copy link
Member Author

Any PR from an account that does not itself have Github actions enabled. #3841 was the last one that had me scrambling to fix tests directly on master after merging the PR. As for an upcoming PR, you can see that #3883 does not have the Windows checks running either.

Unless Github changes their policy to also run Github actions for PRs from forks that do not have themselves Github actions enabled, I am seriously looking for alternatives here.

@shellscape
Copy link
Contributor

shellscape commented Nov 30, 2020

Good lord, that's one hell of a bug in their system. I'm taking to Twitter to see if I can dig up anyone connected to that.

In the mean time, we could check these boxes to make them required, and a user would have to enable actions to get the PR through:
Screen Shot 2020-11-30 at 9 52 10 AM

@lukastaegert
Copy link
Member Author

Seems to work now with Github Actions, so I will close this PR. If we are happy, maybe at some point we can consider moving entirely to Github Actions on the other hand.

@lukastaegert lukastaegert deleted the circleci-windows branch December 9, 2021 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants