Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update chat/support links #3861

Merged
merged 2 commits into from Nov 16, 2020
Merged

docs: update chat/support links #3861

merged 2 commits into from Nov 16, 2020

Conversation

shellscape
Copy link
Contributor

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

We've moved chat to Discord and are closing down the Gitter. This updates all of the links in this repo.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#docs/discord

or load it into the REPL:
https://rollupjs.org/repl/?circleci=13449

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #3861 (68f91b6) into master (fd809d5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
- Coverage   97.07%   97.06%   -0.01%     
==========================================
  Files         184      184              
  Lines        6523     6517       -6     
  Branches     1889     1887       -2     
==========================================
- Hits         6332     6326       -6     
  Misses        101      101              
  Partials       90       90              
Impacted Files Coverage Δ
src/ast/nodes/TryStatement.ts 94.11% <0.00%> (-1.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd809d5...dcc1fd5. Read the comment docs.

@Rich-Harris
Copy link
Contributor

What's the rationale for using a URL shortener? Seems like an unnecessary point of failure

@shellscape
Copy link
Contributor Author

A friendlier presentation, ease of sharing from memory without looking it up. Discord currently lacks a friendly invite url.

@Rich-Harris
Copy link
Contributor

Fair enough. Ideally it'd be https://rollupjs.org/chat, like we have with https://svelte.dev/chat, but that's tricky with a statically exported site (it'd work, sort of, because it just creates a page with <script>location.href = 'blah'</script> but that's not ideal). Maybe that'd make sense once we release SvelteKit and it's possible to make /chat a serverless function that redirects while everything else is static

@shellscape
Copy link
Contributor Author

shellscape commented Nov 10, 2020

Could we just use a meta redirect? I'm not familiar with how the docs site is built, but I could look into it.

@Rich-Harris
Copy link
Contributor

Oh shit, I had no idea such a thing existed. Yeah, if we added a /chat/index.html file to https://github.com/rollup/rollupjs.org/tree/master/static containing

<meta http-equiv="refresh" content="0;url=http://discord.com/whatever"

then it should Just Work?

@Rich-Harris Rich-Harris merged commit 4e0b887 into master Nov 16, 2020
@Rich-Harris Rich-Harris deleted the docs/discord branch November 16, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants