Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide TS declaration file for rollup.browser.js #3860

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeasonstudio
Copy link

@jeasonstudio jeasonstudio commented Nov 9, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
None.

Description

Generate a separate TS declaretion rollup.browser.d.ts for rollup.browser.js

import { rollup, VERSION } from "rollup/dist/rollup.browser";

// ...
rollup({ ... });

@jeasonstudio
Copy link
Author

@lukastaegert My PR checks were broken by other issues, lint errors are not included in the modification of the current PR

@shellscape
Copy link
Contributor

shellscape commented Nov 9, 2020

Thanks for opening a PR. Unfortunately this is not a chore, but rather a feature, so tests are required. Passing CI is a requirement for all PRs. It's also unclear why this is needed, there was no discussion of this feature prior to submitting it. You'll have to make a convincing case for this before we'll be able to consider it.

@jeasonstudio jeasonstudio changed the title chore: provide dts for browser bundle feature: provide dts for rollup.browser.js Nov 12, 2020
@jeasonstudio jeasonstudio changed the title feature: provide dts for rollup.browser.js Provide TS declaration file for rollup.browser.js Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants