Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch: listen for new files #3812

Merged
merged 1 commit into from Oct 8, 2020

Conversation

dmitrage
Copy link
Contributor

@dmitrage dmitrage commented Oct 7, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
#3704

Description

As suggested in the linked issue.

After I added the second test I discovered that it passes without this patch as well but decided to keep it to be sure.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@929f0ac). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3812   +/-   ##
=========================================
  Coverage          ?   97.03%           
=========================================
  Files             ?      185           
  Lines             ?     6477           
  Branches          ?     1876           
=========================================
  Hits              ?     6285           
  Misses            ?      101           
  Partials          ?       91           
Impacted Files Coverage Δ
src/watch/fileWatcher.ts 96.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 929f0ac...20de861. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks a lot! Will release this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants