Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: test case for import namespace when only rendering systemjs #3731

Merged
merged 2 commits into from Aug 16, 2020

Conversation

sastan
Copy link
Contributor

@sastan sastan commented Aug 15, 2020

This MR has no solution for the described problem. I created it as a showcase for the problem and to work on a solution.

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers: #3730

Description

Generating only a systemjs bundle with a namespace export fails. This only happens when no other output is generated for that bundle. If a esm or cjs bundle is generated before the system bundle, the system is valid.

I am willing to create a working MR but i need some pointers where to start. For the moment i'm out of ideas.

@sastan sastan changed the title test case for import namespace when only rendering systemjs WIP: test case for import namespace when only rendering systemjs Aug 15, 2020
@lukastaegert
Copy link
Member

Thanks! I can base a solution on this one if you do not mind.

@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #3731 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3731   +/-   ##
=======================================
  Coverage   96.98%   96.98%           
=======================================
  Files         184      184           
  Lines        6430     6431    +1     
  Branches     1861     1862    +1     
=======================================
+ Hits         6236     6237    +1     
  Misses        103      103           
  Partials       91       91           
Impacted Files Coverage Δ
src/Chunk.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f8c47...3d348e9. Read the comment docs.

@lukastaegert lukastaegert merged commit 18df9a6 into rollup:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants