Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs > Tutorial > Improve discoverability of manualChunks for code splitting #3631

Merged
merged 2 commits into from Jun 12, 2020

Conversation

zlamma
Copy link
Contributor

@zlamma zlamma commented Jun 11, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Wasted quite some time to learn that manualChunks exists. This change is what I think would help me find it earlier.

@codecov
Copy link

codecov bot commented Jun 11, 2020

Codecov Report

Merging #3631 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3631   +/-   ##
=======================================
  Coverage   96.54%   96.54%           
=======================================
  Files         182      182           
  Lines        6243     6243           
  Branches     1832     1832           
=======================================
  Hits         6027     6027           
  Misses        107      107           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c063df7...51d01b6. Read the comment docs.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think lazy loading instead of late loading would be the canonical adjective here, otherwise looks good

@zlamma zlamma changed the title Improve discoverability of manualChunks for code splitting Docs > Tutorial > Improve discoverability of manualChunks for code splitting Jun 12, 2020
Remark from [this comment](rollup#3631 (review))

plus a minor improvement of precision in the parenthesis describing what it is.
@zlamma
Copy link
Contributor Author

zlamma commented Jun 12, 2020

Thanks @lukastaegert . Changed to 'lazy' as per suggestion.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@lukastaegert lukastaegert merged commit ad24b6a into rollup:master Jun 12, 2020
@zlamma zlamma deleted the patch-1 branch April 23, 2021 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants