Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle side-effects next to side-effect-free default exports in case the default export is reexported #3602

Merged
merged 1 commit into from May 28, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3565

Description

Apparently side-effects next to a default export statement were still not included when there were side-effect-free modules in between through which the default is reexported as a named export.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3565-default-reexport

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11471

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #3602 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3602   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         180      180           
  Lines        6149     6151    +2     
  Branches     1807     1808    +1     
=======================================
+ Hits         5925     5927    +2     
  Misses        111      111           
  Partials      113      113           
Impacted Files Coverage Δ
src/Module.ts 98.90% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca0854e...b7f9b08. Read the comment docs.

@lukastaegert lukastaegert merged commit 41778fe into master May 28, 2020
@lukastaegert lukastaegert deleted the gh-3565-default-reexport branch May 28, 2020 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup treeshaking remove "augmentation-and-re-export" code. (Different behaviour with webpack)
2 participants