Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle default exporting "undefined" #3558

Merged
merged 1 commit into from May 15, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3557

Description

This will make sure that the default export simplification logic does not kick in when undefined is exported, leading to a crash.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3557-undefined-default-export

or load it into the REPL:
https://rollupjs.org/repl/?circleci=11061

@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #3558 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3558   +/-   ##
=======================================
  Coverage   96.29%   96.29%           
=======================================
  Files         176      176           
  Lines        6048     6049    +1     
  Branches     1783     1784    +1     
=======================================
+ Hits         5824     5825    +1     
  Misses        112      112           
  Partials      112      112           
Impacted Files Coverage Δ
src/ast/variables/ExportDefaultVariable.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb20e62...92ab11d. Read the comment docs.

@lukastaegert lukastaegert merged commit 336eca8 into master May 15, 2020
@lukastaegert lukastaegert deleted the gh-3557-undefined-default-export branch May 15, 2020 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error: "Cannot read property 'getDependenciesToBeIncluded' of undefined" after upgrading to v2.10.0
2 participants