Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle default exporting global variables #3526

Merged
merged 1 commit into from Apr 30, 2020

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
May or may not solve #3523

Description

When reworking the default export short-cut logic, I did not consider in some cases what should happen if a global variable is default-exported. This fixes it.

@rollup-bot
Copy link
Collaborator

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-3523-export-default-global

or load it into the REPL:
https://rollupjs.org/repl/?circleci=10770

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #3526 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3526   +/-   ##
=======================================
  Coverage   96.22%   96.22%           
=======================================
  Files         176      176           
  Lines        5982     5984    +2     
  Branches     1763     1765    +2     
=======================================
+ Hits         5756     5758    +2     
  Misses        112      112           
  Partials      114      114           
Impacted Files Coverage Δ
src/Chunk.ts 99.77% <100.00%> (ø)
src/Module.ts 98.91% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2b4883...30ff894. Read the comment docs.

@lukastaegert lukastaegert merged commit 1b588b6 into master Apr 30, 2020
@lukastaegert lukastaegert deleted the gh-3523-export-default-global branch April 30, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants