Preserve asm.js code #3362
Merged
Preserve asm.js code #3362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
approved these changes
Jan 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #3362 +/- ##
=======================================
Coverage 93.26% 93.27%
=======================================
Files 172 172
Lines 6074 6082 +8
Branches 1808 1812 +4
=======================================
+ Hits 5665 5673 +8
Misses 218 218
Partials 191 191 Continue to review full report at Codecov.
|
…If we add "initial values" to instance variables in TypeScript, they are assigned AFTER the constructor is done, while "initialise" is done DURING the constructor call
This was referenced Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Resolves #3360
Description
This will automatically include any code inside a "use asm" block unmodified, see #3360 for reasoning.