Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle circular reexports #3350

Merged
merged 4 commits into from Jan 21, 2020

Conversation

lukastaegert
Copy link
Member

@lukastaegert lukastaegert commented Jan 20, 2020

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
Resolves #3348

Description

This adds a break-off condition when searching variables for export names. It prevents maximum callstack exceeded errors for both named and namespace circular reexports.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #3350 into master will increase coverage by 0.01%.
The diff coverage is 88.7%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3350      +/-   ##
==========================================
+ Coverage   93.22%   93.23%   +0.01%     
==========================================
  Files         172      172              
  Lines        6038     6047       +9     
  Branches     1800     1803       +3     
==========================================
+ Hits         5629     5638       +9     
  Misses        218      218              
  Partials      191      191
Impacted Files Coverage Δ
src/utils/collapseSourcemaps.ts 90% <0%> (ø) ⬆️
src/ast/nodes/TaggedTemplateExpression.ts 63.63% <0%> (ø) ⬆️
src/utils/defaultPlugin.ts 94% <0%> (ø) ⬆️
src/utils/FileEmitter.ts 100% <100%> (ø) ⬆️
src/ast/nodes/Identifier.ts 100% <100%> (ø) ⬆️
src/ast/nodes/MemberExpression.ts 98.27% <100%> (ø) ⬆️
src/utils/PluginDriver.ts 100% <100%> (ø) ⬆️
src/ast/nodes/CallExpression.ts 95.41% <100%> (ø) ⬆️
src/finalisers/umd.ts 94.91% <100%> (ø) ⬆️
src/utils/getExportMode.ts 100% <100%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56cbbdc...7efcffb. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded at Module.getVariableForExportName
1 participant